Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis testing to Irssi scripts. #14

Merged
merged 1 commit into from
Jun 30, 2014
Merged

Add travis testing to Irssi scripts. #14

merged 1 commit into from
Jun 30, 2014

Conversation

ailin-nemui
Copy link
Contributor

This is start of issue #9

@ahf
Copy link
Member

ahf commented Jun 18, 2014

Overall, I think this is good. I do however want the .zsh files to be converted to either bash or posix sh. It should be possible for other people to run these checks locally without having to install a new shell.

The sample reports looks really cool. Very good job.

@ailin-nemui
Copy link
Contributor Author

I think this should be good now. To enable commit rights, you need to create an App Token on an account with access to the repo, then run "travis encrypt REPO_LOGIN_TOKEN=yourtokenhere --add" inside the check-out and commit the key

ahf added a commit that referenced this pull request Jun 30, 2014
Add travis testing to Irssi scripts.
@ahf ahf merged commit 223d960 into irssi:gh-pages Jun 30, 2014
@ahf
Copy link
Member

ahf commented Jun 30, 2014

Very nice, thanks! Let's see how this go.

@GeertHauwaerts
Copy link
Member

I see a big amount of scripts in the whitelist, what exactly needs to be changed in those scripts in order to make them compliant?

@ailin-nemui
Copy link
Contributor Author

@GeertHauwaerts the (very arbitrary) rules we set for now are: compiles, loads, uses strict all the way through, and has %IRSSI & $VERSION. See https://github.com/irssi/scripts.irssi.org/tree/gh-pages/_testing#irssi-scripts-testing.

Once you enable the commit rights for travis, it will generate a HTML report including links to the extracted log files for easier fixing of scripts. Until then, you can look at the raw results table visible in the build log at https://travis-ci.org/irssi/scripts.irssi.org which should show up if it was properly enabled (but which is not as complete)

Click on the triangle next to $ ./_testing/travis/show-failures.zsh (at the very end) to see the log messages of scripts that failed to load/compile.

The others will be failures due to missing $VERSION ("HDR") or strictures ("CRIT")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants