Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to sbt-web 1.5 for compatibility with play2.10/3 #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update to sbt-web 1.5 for compatibility with play2.10/3 #53

wants to merge 1 commit into from

Conversation

OlegYch
Copy link

@OlegYch OlegYch commented Jan 3, 2024

No description provided.

mkurz
mkurz reviewed Jan 25, 2024
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
@mkurz
Copy link

mkurz commented Jan 25, 2024

@irundaia Can you take a look here?

@mkurz mkurz mentioned this pull request Jan 25, 2024
Merged
2 tasks
@OlegYch OlegYch force-pushed the sbtweb1.5 branch 2 times, most recently from 52bb2b4 to 69873ff Compare January 26, 2024 01:22
@mkurz
Copy link

mkurz commented Jan 26, 2024

@OlegYch I think it would be good if you bump the sbt version in project/build.properties to 1.9.7.

Also I am not sure if this PR should actually be targeted against the migrate_to_dart branch, because it looks like this is where latest 1.5.2 was tagged on... and also latest work was done there.
@irundaia Seems like the branches got mixed up, maybe you can resolve that? Also it would be really good to get sbt-web upgraded to 1.5.x...

@OlegYch
Copy link
Author

OlegYch commented Jan 26, 2024

@mkurz looks like there is only one commit in migrate_to_dart which was released, the rest seem more like wip
i guess it would be better to merge that commit in master when releasing

@OlegYch
Copy link
Author

OlegYch commented Jan 26, 2024

@mkurz updated sbt and fixed some deprecations

@mkurz
Copy link

mkurz commented Jan 26, 2024

@OlegYch Please use sbt 1.9.7, sbt 1.9.8 is known to have problems with Java 8.

@OlegYch
Copy link
Author

OlegYch commented Jan 26, 2024

@mkurz huh, ok

@mkurz mkurz mentioned this pull request Jan 29, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurz mkurz mkurz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OlegYch @mkurz