Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate if the initial call to registerSelfToTST() is needed #1

Closed
irvinm opened this issue Jun 22, 2020 · 2 comments
Closed

Evaluate if the initial call to registerSelfToTST() is needed #1

irvinm opened this issue Jun 22, 2020 · 2 comments
Labels
fixed Fixed question Further information is requested

Comments

@irvinm
Copy link
Owner

irvinm commented Jun 22, 2020

There is an initial call, then I added another call after the "ready" message is sent.

It seems to work now, but wondering if the first call is really needed or not.

@irvinm irvinm added the question Further information is requested label Jun 22, 2020
@irvinm
Copy link
Owner Author

irvinm commented Jun 26, 2020

Look at TST doc example: https://github.com/piroor/treestyletab/blob/trunk/doc/boilerplate-helper-background.js

It is more async vs. sync with more error checking.

@irvinm irvinm added the fixed Fixed label Sep 13, 2020
@irvinm
Copy link
Owner Author

irvinm commented Sep 13, 2020

As of v1.1.1, I have added some retry logic around registerSelfToTST() with check-in: c5f3c92. It is clear that some calls to register to TST are made before TST is fully loaded and the try\catch logic has to take that into account and retry registering to TST until it is successful.

@irvinm irvinm closed this as completed Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Fixed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant