Speed up setting browser

src/General-Rules-Tests/ReSmalllintTest.class.st

@@ -33,18 +33,11 @@ ReSmalllintTest >> assertEnvironment: anEnvironment hasAllMethodsOfTheResult: cr
 
 { #category : 'private' }
 ReSmalllintTest >> assertIsValidRule: aRule [
-	self
-		assert: (aRule name isString and: [ aRule name notEmpty ])
-		description: 'Missing rule name'.
-	self
-		assert: (aRule group isString and: [ aRule group notEmpty ])
-		description: 'Missing group name'.
-	self
-		assert: (aRule rationale isString and: [ aRule rationale notEmpty ])
-		description: 'Missing rationale'.
-	self
-		assert: (#(error warning information) includes: aRule severity)
-		description: 'Invalid severity'
+
+	self assert: (aRule name isString and: [ aRule name isNotEmpty ]) description: 'Missing rule name'.
+	self assert: (aRule group isString and: [ aRule group isNotEmpty ]) description: 'Missing group name'.
+	self assert: (aRule rationale isString and: [ aRule rationale isNotEmpty ]) description: 'Missing rationale'.
+	self assert: (#( error warning information ) includes: aRule severity) description: 'Invalid severity'
 ]
 
 { #category : 'asserting' }

src/General-Rules/ReLongMethodsRule.class.st

@@ -27,6 +27,11 @@ ReLongMethodsRule class >> group [
 	^ 'Design Flaws'
 ]
 
+{ #category : 'private' }
+ReLongMethodsRule class >> longMethodSize [
+	^ 20
+]
+
 { #category : 'accessing' }
 ReLongMethodsRule class >> rationale [
 	^ 'This smell arises when a long method is found (with {1} or more statements). Note that, it counts statements, not lines. Long methods should often be split into several smaller ones.
@@ -70,5 +75,5 @@ ReLongMethodsRule >> basicCheck: aMethod [
 
 { #category : 'private' }
 ReLongMethodsRule >> longMethodSize [
-	^ 20
+	^ self class longMethodSize
 ]

src/Renraku/ReRuleManager.class.st

@@ -160,23 +160,21 @@ ReRuleManager class >> ruleToggleGroupID [
 
 { #category : 'settings' }
 ReRuleManager class >> ruleToggleSettingsOn: aBuilder [
+
 	<systemsettings>
 	(aBuilder group: self ruleToggleGroupID)
 		order: 1;
 		label: 'Toggle rules to run';
 		description: 'Select which rules do you want to see in the live feedback';
 		parent: #qualityAssistant;
 		with: [
-			(self visibleRuleClasses sorted: [ :a :b | a name < b name ])
-				do: [ :rule |
-					| inst |
-					inst := rule new.
+			(self visibleRuleClasses sorted: [ :a :b | a name < b name ]) do: [ :rule |
 					(aBuilder setting: rule enabledSettingID)
-					selector: #enabled;
-					target: rule;
-					default: rule enabled;
-					label: inst name;
-					description: inst rationale ] ]
+						selector: #enabled;
+						target: rule;
+						default: rule enabled;
+						label: rule name;
+						description: rule rationale ] ]
 ]
 
 { #category : 'accessing' }