Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isatab2json conversion throws AttributeError in createExecuteStudyProtocol() #43

Closed
djcomlab opened this issue Dec 23, 2015 · 4 comments
Assignees
Milestone

Comments

@djcomlab
Copy link
Member

Converting BII-I-1 is unsuccessful, throwing up the following error when running test_isatab2json.py and elsewhere:

Error
Traceback (most recent call last):
  File "/PycharmProjects/isa-api/tests/test_isatab2json.py", line 19, in test_bii_i_1_conversion
    isa_json = self.isatab2json.convert(test_data_dir, self.sample_data_dir)
  File "/PycharmProjects/isa-api/isatools/convert/isatab2json.py", line 49, in convert
    ("studies", self.createStudies(isa_tab.studies))
  File "//PycharmProjects/isa-api/isatools/convert/isatab2json.py", line 215, in createStudies
    ("processSequence", self.createProcessSequence(study.process_nodes, source_dict, sample_dict, data_dict)),
  File "/PycharmProjects/isa-api/isatools/convert/isatab2json.py", line 270, in createProcessSequence
    ("executesProtocol", self.createExecuteStudyProtocol(process_node_name, process_nodes[process_node_name])),
  File "/PycharmProjects/isa-api/isatools/convert/isatab2json.py", line 305, in createExecuteStudyProtocol
    ("name", process_node.protocol)
AttributeError: 'ProcessNodeRecord' object has no attribute 'protocol'
@agbeltran
Copy link
Contributor

I cannot reproduce this error when running in feat/conversion nor develop branches. Maybe you ran it from a branch which didn't have the latest code?

@djcomlab
Copy link
Member Author

djcomlab commented Jan 6, 2016

I just now checked out and pulled for both develop and feat/conversion and still get the same error!

@agbeltran
Copy link
Contributor

Thanks for checking - the reason is some changes to the parser, I will push them soon.

@agbeltran
Copy link
Contributor

Should be fixed now - please reopen if it isn't.

@agbeltran agbeltran added this to the Release 0.1 milestone Jan 26, 2016
@agbeltran agbeltran self-assigned this Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants