-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace networkidle with waitFor #8
Comments
Hey, thanks for bringing this up. A few questions:
|
I noticed it on the dashboard page. The page was loaded and networkidle was triggered but there where no
In my private version I also save the browser local storage after the login happend and the dashboard is loaded to prevent a relogin for the next execution. I did it because I run the script every 5 minutes on my server and to quick logins seems to trigger a rate limit by strava and then they add a captcha check on the login page. This is the documentation for the storage stuff: You don't need to persist the session storage the first example is enough. Should be pretty easy to persist the json for further github actions runs |
Nice find on the session storage stuff. We could implement that if we choose to. As for the lazy loading from strava, any idea what triggers the loading? A scroll maybe? or any random action? There might be a chance that we switch to |
The ajax call just needs some time, I currently still use networkidle but with another delay of 2sec. This also works fine but could break in the future. |
I see. Have you tried using |
Not yet, didn't have time for it and I am also busy the next 1-2 weeks. But the docs sound promising for this case |
All good, I'm in a similar situation in the next few weeks. Once some testing has been done and if it seems to be more reliable, then we can look at a PR together. Thanks again for bringing this up. |
I messed around with waitFor, couldn't get it to work... retries still timing out. Will keep messing with it. |
Closing this now. Feel free to reopen later. |
Note that #11 is related to the lazy loading discussion. Instead of |
I noticed that Strava seem to have changed their page lazy loading behaviour. Maybe we should switch from networkidle to waitFor (https://playwright.dev/python/docs/api/class-locator#locator-wait-for) for the dashboard page load.
The text was updated successfully, but these errors were encountered: