Fix libgit2#37, OID conversion with NULL bytes

isaac · Dec 6, 2011 · 729eeef · 729eeef
1 parent da3f66d
commit 729eeef
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/ext/rugged/rugged.c b/ext/rugged/rugged.c
@@ -43,7 +43,11 @@ static VALUE rb_git_raw_to_hex(VALUE self, VALUE raw)
 	char out[40];
 
 	Check_Type(raw, T_STRING);
-	git_oid_fromraw(&oid, StringValueCStr(raw));
+
+	if (RSTRING_LEN(raw) != GIT_OID_RAWSZ)
+		rb_raise(rb_eTypeError, "Invalid buffer size for an OID");
+
+	git_oid_fromraw(&oid, RSTRING_PTR(raw));
 	git_oid_fmt(out, &oid);
 
 	return rugged_str_new(out, 40, NULL);

diff --git a/test/lib_test.rb b/test/lib_test.rb
@@ -30,4 +30,11 @@
     hex2 = raw.unpack("H*")[0]
     assert_equal hex1, hex2
   end
+
+  test "converts raw into hex with null bytes" do
+    raw = Rugged::hex_to_raw("702f00394564b24052511cb69961164828bf5494")
+    hex1 = Rugged::raw_to_hex(raw)
+    hex2 = raw.unpack("H*")[0]
+    assert_equal hex1, hex2
+  end
 end