Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default code formatting off #86

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Default code formatting off #86

merged 1 commit into from
Feb 28, 2024

Conversation

isaacbrodsky
Copy link
Owner

See also #85

@isaacbrodsky isaacbrodsky mentioned this pull request Feb 28, 2024
Closed
@isaacbrodsky isaacbrodsky merged commit 7fd6873 into main Feb 28, 2024
16 checks passed
@isaacbrodsky isaacbrodsky deleted the default-format-off branch February 28, 2024 15:02
@carlopi
Copy link
Contributor

carlopi commented Feb 28, 2024 •
edited
Loading

I was wrong, turns out #85 and #86 are not equivalent, since ENABLE_LINTING with this PR will not be propagated to h3, causing that formatter to run and generating a bunch of:

Invalid value for -style
Invalid value for -style
Invalid value for -style

Would it be possible to somehow have the inner ENABLE_LINTING also not triggered? Thanks!

@isaacbrodsky
Copy link
Owner Author

That is certainly unexpected! I will take a look at how to disable that.

@isaacbrodsky isaacbrodsky mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@isaacbrodsky @carlopi