Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/function to overwrite response headers #104

Merged
merged 9 commits into from
Sep 11, 2021

Conversation

isaacgr
Copy link
Owner

@isaacgr isaacgr commented Sep 11, 2021

Use setResponseStatus to overwrite response status code

  • rename from setResponseHeaders
  • add class attribute for headers and status code
  • if status code is set, then dont use the one generated from the message
    (this allows a user to overwrite the status if its not one of the ones in
    errorToStatus)
  • send response for notification in gotNotification
  • Use .end() to send body data in response.write() and writeHead()

@isaacgr isaacgr merged commit 467fd3c into master Sep 11, 2021
@isaacgr isaacgr deleted the task/function_to_overwrite_response_headers branch September 11, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant