Improvement/#65/improve tests #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
isaacgr
commented
Nov 21, 2020
isaacgr
commented
- Remove custom wording and phrases from tests
- Properly use before/after to connect and disconnect clients and servers
- Use pool of test clients and servers with the same ports for tests
- Add component tests specifically for new class library methods and structure
- Organize test folders and remove some unecessary tests
- Correctly use before/after hooks within describe blocks - Open and close server connections before each test block to remove need for unique ports - Remove unecessary batchResponse listener tests - Remove v1 server from client tests (since client version determines server response if server is v2)
- uses .close() instead of .destroy()
- open and close server/client connections after each test block - use the same port and methods for all servers - use imported servers and clients from test-client and test-server files - update v1 tests
- had to comment out #54 request timeout test for http due to socket hang up error
Rename node ws client test
Remove extra delimiter from server notifications.
Add delimiter before calling writeToClient in gotError.
Reject notification if no method given.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.