fix(execute): Handle errors gracefully during menuItem execution

isaacplmann · Apr 26, 2017 · f586f86 · f586f86
1 parent 6630974
commit f586f86
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,12 @@
+<a name="1.0.4"></a>
+# [1.0.4](https://github.com/isaacplmann/ngx-contextmenu) (2017-04-26)
+
+
+### Bug Fixes
+
+* **execute:** Handle errors gracefully during menuItem execution
+
+
 <a name="1.0.3"></a>
 # [1.0.3](https://github.com/isaacplmann/ngx-contextmenu) (2017-04-11)
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-contextmenu",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "An Angular component to show a context menu on an arbitrary component",
   "keywords": [
     "angular2",

diff --git a/src/demo/app.component.ts b/src/demo/app.component.ts
@@ -60,7 +60,7 @@ export class AppComponent {
       },
       actions: [{
         enabled: true,
-        execute: (item: any): void => console.log(item),
+        execute: (item: any): void => { (<any>window).fake.doesntexist = 2; },
         html: (item: any): string => `Joe something: ${item.name}`,
         visible: true,
       }],

diff --git a/src/lib/contextMenuContent.component.ts b/src/lib/contextMenuContent.component.ts
@@ -50,7 +50,7 @@ export interface MouseLocation {
             [attr.role]="menuItem.divider ? 'separator' : undefined">
           <a *ngIf="!menuItem.divider && !menuItem.passive" href [class.dropdown-item]="useBootstrap4"
             [class.disabled]="useBootstrap4 && !isMenuItemEnabled(menuItem)"
-            (click)="menuItem.triggerExecute(item, $event); $event.preventDefault(); $event.stopPropagation();">
+            (click)="$event.preventDefault(); $event.stopPropagation(); menuItem.triggerExecute(item, $event);">
             <ng-template [ngTemplateOutlet]="menuItem.template" [ngOutletContext]="{ $implicit: item }"></ng-template>
           </a>