Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bidi): Implement RTL support #170

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(bidi): Implement RTL support #170

wants to merge 4 commits into from

Conversation

amitbeck
Copy link

@amitbeck amitbeck commented Sep 4, 2019 •
edited
Loading

image

Closes #155.

When direction is RTL:

  • sub menus are opened to the left by default,
  • menu items containing sub menus are indicated with an arrow pointing to the left.
  • text is aligned to the right.
  • left arrow key opens sub menu,
  • right arrow key closes the sub menu.

NOTE: Please notice that in order to actually enable RTL, either document.body (<body>) or document.documentElement (<html>) needs to have the dir attribute set to "rtl", otherwise it won't work.

@amitbeck amitbeck changed the title Implement RTL support feat(bidi): Implement RTL support Sep 4, 2019
@amitbeck
Copy link
Author

Could this PR be merged please? @isaacplmann

@amitbeck
Copy link
Author

amitbeck commented Sep 9, 2020

@isaacplmann It's been a whole year since I've published this PR. Why not merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTL support
1 participant
@amitbeck