added navigation by arrows inside context menu #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacplmann
requested changes
Jun 27, 2017
There was a problem hiding this comment.
You'll need some way of determining which context menu is the currently focused one (leaf menu) - so that you don't have multiple context menu items selected when sub menus are open.
Here's what I recommend:
- Look at ContextMenuComponent.destroyLeafMenu to see how the escape key only removes the leaf menu.
- Update
ContextMenuServiceto provide agetLeafMenufunction that returns theContextMenuContextComponentthat is the current leaf menu. - Use that information to conditionally trigger the key bindings.
| @@ -216,6 +226,62 @@ export class ContextMenuContentComponent implements OnInit, OnDestroy, AfterView | |||
| this.changeDetector.markForCheck(); | |||
| } | |||
|
|
|||
| @HostListener('document:keydown', ['$event']) | |||
There was a problem hiding this comment.
You can let angular handle a lot of this KeyboardEvent logic for you by using listeners like document:keydown.ArrowDown on the relevant functions directly.
|
Good work solving the tabbing issue by tracking the |
|
Could you help with your comments? |
|
I'm merging this in to finish working on it. Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added navigation by arrows inside context menu