Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event emitter leak by setting listener on process exit only once #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

froucher
Copy link

@froucher froucher commented Nov 8, 2015

This PR must resolve errors with eventEmitter memory leaks.

(node) warning: possible EventEmitter memory leak detected. 11 exit listeners added. Use emitter.setMaxListeners() to increase limit.
Trace
    at process.addListener (events.js:179:15)
    at process.on.process.addListener (node.js:668:26)
    at spinner (/usr/local/lib/node_modules/gitwalk/node_modules/char-spinner/spin.js:35:13)
    at Object.getUpToDateRefs (/usr/local/lib/node_modules/gitwalk/out/lib/git.js:107:18)

The code was copied from two commits in another fork from atlassian (atlassian-forks@5c31a18 and atlassian-forks@330819a)

@stevenvachon
Copy link

Please fix broken tests.

@stevenvachon
Copy link

@froucher ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants