New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal properly with uppercase .GIT file basenames on web editor like for lowercase .git #318

Open
cirosantilli opened this Issue Dec 20, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@cirosantilli
Collaborator

cirosantilli commented Dec 20, 2014

Either:

  • on web UI blob create / rename, validate it nicely like for the lowercase .git.

If you try to create a file named .git file from the web editor, it automatically removes that path component / deactivates the commit button.

But if you use .GIT with upper case the creation fails less gracefully.

  • allow uppercase .GIT. I think this is the best possibility.

It is currently blocked on push and API.

Git itself allows it, so it is an unnecessary restriction.

GitHub can already currently deal with case sensitive files, e.g.: https://github.com/cirosantilli/test/blob/54203288c929edca978088d51b55b6b5ac0b3eca/CASE and https://github.com/cirosantilli/test/blob/54203288c929edca978088d51b55b6b5ac0b3eca/case

GitLab allows it: https://gitlab.com/cirosantilli/test-GIT/tree/master

@cirosantilli

This comment has been minimized.

Collaborator

cirosantilli commented Dec 24, 2014

They've replied (but I don't know who: it only says "GitHub Staff" this time).

OK, after https://github.com/blog/1938-vulnerability-announced-update-your-git-clients Git will blacklist uppercase .GIT from being tracked, so allowing .GIT is out. I though it was going to get fixed by just not checking things out.

Next, they've already improved the UI validation, but it is still different from lowercase .git:

  • .git/ disappears on the fly via Js like before.
  • .GIT/ gives an in page error error: "That path contains a malformed path component. Please choose a different path and try again.". It's already better since you don't go to a dead end page, but could be more uniform.

@cirosantilli cirosantilli reopened this Dec 24, 2014

@stuartpb

This comment has been minimized.

stuartpb commented Jan 11, 2015

Yeah, .GIT is a bad citizen in the cross-platform Git community, so I'm all in favor of blacklisting it (especially since that's what the mainline client does now by default). Agreed that GitHub should unify their solutions, though (not allowing the commit from the editor in realtime, the same way as .git).

Out of curiosity, if you bypass the .git prevention JS to post a file creation, does it give you the same error as .GIT currently does?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment