Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Cannot create a pull request from a branch name that contains emoji with the "Compare & Pull request" button #752

Open
camsaul opened this issue Aug 24, 2016 · 5 comments
Labels

Comments

@camsaul
Copy link

camsaul commented Aug 24, 2016

Normally when I push a branch I'll see a message like this in my Slack:

screen shot 2016-08-24 at 4 34 23 pm

Now if I push a branch called ":shower:" I'll see this instead:

screen shot 2016-08-24 at 4 35 12 pm

And when I go to the home page of my repo it mentions that I pushed branches, but doesn't show the name:

screen shot 2016-08-24 at 4 35 36 pm

Clicking the "Compare & Pull Request" button doesn't work; I have to manually open a PR for the branch the hard way by looking through the list of all my branches and finding the appropriate one.

Anyways... I don't know the full extent of this issue (whether it extends to unicode characters in general or not). But I would like if GitHub better-supported emoji names for branches since a picture is worth a thousand words, as they say.

@cirosantilli
Copy link
Collaborator

How did you manage to push a branch called :shower:?

Current git considers that illegal: http://stackoverflow.com/questions/3651860/which-characters-are-illegal-within-a-branch-name

@camsaul
Copy link
Author

camsaul commented Aug 26, 2016

I didn't push :shower: I pushed the actual Unicode character (U+1F6BF)

@cirosantilli
Copy link
Collaborator

cirosantilli commented Aug 27, 2016

Ah OK. Currently, it is possible to merge such a named branch: cirosantilli/test-git-web-interface#21 , but I haven't tried from the create pull request button you mention.

But we can only create such branches from the web UI, otherwise a hook rejects the push with:

 ! [remote rejected] 🚿 -> 🚿 (pre-receive hook declined)

Unicode in general is alright it seems: https://github.com/cirosantilli/test-git-web-interface/tree/%E4%B8%AD%E6%96%87

@cirosantilli cirosantilli changed the title Buggy support for branches whose names are an emoji Cannot create a pull request on a branch name that contains emoji with the "Compare & Pull request" button Aug 27, 2016
@cirosantilli cirosantilli changed the title Cannot create a pull request on a branch name that contains emoji with the "Compare & Pull request" button Cannot create a pull request from a branch name that contains emoji with the "Compare & Pull request" button Aug 27, 2016
@eligundry
Copy link

eligundry commented Nov 18, 2016

I'm having a similar issue. When I push up a branch with an emoji in it, the widget on the repo's home page that allows for quick opening of a PR will not render emoji and clicking on the open PR button will point to the wrong branch.

screenshot 2016-11-18 12 05 11

There should be a 💯 emoji there at the end.

@TPS
Copy link
Collaborator

TPS commented Nov 22, 2016

Similar emoji-handling issues in #816 😢

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants