Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bundling library using webpack #190

Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix: bundling library using webpack #190

merged 1 commit into from
Jan 17, 2023

Conversation

AviVahl
Copy link
Contributor

@AviVahl AviVahl commented Jan 16, 2023 •
edited
Loading

this change ensures "default" conditions are last, fixing the following webpack bundling error (on import to lib):

Module not found: Error: Default condition should be last one

@AviVahl
Copy link
Contributor Author

AviVahl commented Jan 17, 2023

Rebased to current main.

@isaacs
Copy link
Owner

isaacs commented Jan 17, 2023

What a very bizarre requirement. But ok, sure. I'll update the other hybrid modules I have to work the same way.

@AviVahl @isaacs
fix: bundling library using webpack
9f72189 
this change ensures "default" conditions are last, fixing the following
webpack bundling error:

```
Module not found: Error: Default condition should be last one
```

PR-URL: #190
Credit: @AviVahl
Close: #190
Reviewed-by: @isaacs
@isaacs isaacs closed this in 9f72189 Jan 17, 2023
@isaacs isaacs merged commit 9f72189 into isaacs:main Jan 17, 2023
@AviVahl
Copy link
Contributor Author

AviVahl commented Jan 17, 2023

Thanks! ❤️

@AviVahl AviVahl deleted the avi/fix-webpack-bundling branch January 17, 2023 22:18
isaacs added a commit to isaacs/node-mkdirp that referenced this pull request Jan 17, 2023
@isaacs
fix: bundling library using webpack
475d2c9 
this change ensures "default" conditions are last, fixing the following
webpack bundling error:

```
Module not found: Error: Default condition should be last one
```

Re: isaacs/minimatch#190
Credit: @AviVahl
Reviewed-by: @isaacs
isaacs added a commit to isaacs/rimraf that referenced this pull request Jan 17, 2023
@isaacs
fix: bundling library using webpack
ad72d73 
this change ensures "default" conditions are last, fixing the following
webpack bundling error:

```
Module not found: Error: Default condition should be last one
```

Re: isaacs/minimatch#190
Credit: @AviVahl
Reviewed-by: @isaacs
isaacs added a commit to isaacs/node-glob that referenced this pull request Jan 18, 2023
@isaacs
fix: bundling library using webpack
929b0be 
this change ensures "default" conditions are last, fixing the following
webpack bundling error:

```
Module not found: Error: Default condition should be last one
```

Re: isaacs/minimatch#190
Credit: @AviVahl
Reviewed-by: @isaacs
isaacs added a commit to isaacs/node-glob that referenced this pull request Feb 27, 2023
@isaacs
fix: bundling library using webpack
9bc4065 
this change ensures "default" conditions are last, fixing the following
webpack bundling error:

```
Module not found: Error: Default condition should be last one
```

Re: isaacs/minimatch#190
Credit: @AviVahl
Reviewed-by: @isaacs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AviVahl @isaacs