Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: readme #43

Merged
merged 1 commit into from
Nov 28, 2022
Merged

fix: readme #43

merged 1 commit into from
Nov 28, 2022

Conversation

Its-Just-Nans
Copy link
Contributor

@Its-Just-Nans Its-Just-Nans commented Aug 4, 2022 •
edited

The README.md example looks incorrect

If Minipass is async, the output isn't

// output:
// before write
// data event
// after write

But if Minipass is sync (like in the PR), the output is correct

@Its-Just-Nans @isaacs
fix: readme
425e915 
PR-URL: isaacs#43
Credit: @Its-Just-Nans
Close: isaacs#43
Reviewed-by: @isaacs
@isaacs isaacs closed this in 425e915 Nov 28, 2022
@isaacs isaacs merged commit 425e915 into isaacs:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Its-Just-Nans @isaacs