Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nonull regression #176

Closed
schnittstabil opened this issue Mar 9, 2015 · 1 comment
Closed

nonull regression #176

schnittstabil opened this issue Mar 9, 2015 · 1 comment

Comments

@schnittstabil
Copy link
Contributor

Looks like there is a regression in the nonull handling, same as in #43:

$ node -e " console.log( require('glob').sync('xyz', {nonull: true}) ); "
[]

Expected:

[ 'xyz' ]

The behavior changed from 033402b to 3f9b970, i.e. between v4.0.6 and v4.1.0.

NB, the following works as expected:

$ node -e " console.log( require('glob').sync('xyz*', {nonull: true}) ); "
[ 'xyz*' ]
@schnittstabil
Copy link
Contributor Author

The async behavior also changed some commits later: 5a40b67 (that's also between v4.0.6 and v4.1.0):

$ node -e " require('glob')('xyz', {nonull: true}, function(e, f) { console.log(f) } ); "
[]

schnittstabil added a commit to schnittstabil/node-glob that referenced this issue Mar 10, 2015
schnittstabil added a commit to schnittstabil/node-glob that referenced this issue Mar 10, 2015
schnittstabil added a commit to schnittstabil/node-glob that referenced this issue Mar 10, 2015
@isaacs isaacs closed this as completed in 1f5c8aa Mar 11, 2015
isaacs pushed a commit that referenced this issue Mar 11, 2015
isaacs pushed a commit that referenced this issue Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant