Breaking change in 6.0.2 #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit eb6319f.
|
Confirmed breakage.
This is exactly the case for me, the simplified pattern is |
|
Indeed! Landed this with a comment so that I don't go breaking it again. Thanks for the patch. |
|
You could add a test so that you don’t go breaking it again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eb6319f broke backward compatibility for me.
I do not yet have a simple example to take a look at, but I have isolated the breakage to this single file change.
From looking at the commit the change seems surely functional - the option defaults have been changed!