Allow custom fs adapter to be passed as option (#280) #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikkemperman
force-pushed
the
feature-fs-option
branch
2 times, most recently
from
71bfe1f
to
551f67a
Compare
This was referenced Sep 6, 2016
|
Maybe point out the obvious: I haven't considered changes for the sync case yet. Also, it just occurred to me I've just assumed custom adapters would support |
erikkemperman
force-pushed
the
feature-fs-option
branch
from
551f67a
to
fc1975e
Compare
|
I've added the synchronous counterpart, and tentatively simplified to pre-empt Will leave this as it is for now, until you get a chance to look at it (or decide it's a bad idea). Apologies for having submitted this a bit prematurely! |
erikkemperman
force-pushed
the
feature-fs-option
branch
2 times, most recently
from
e359193
to
b6d28d5
Compare
erikkemperman
force-pushed
the
feature-fs-option
branch
from
b6d28d5
to
e61066a
Compare
|
Rebased onto latest master. |
erikkemperman
force-pushed
the
feature-fs-option
branch
from
e61066a
to
6cbdbd6
Compare
11 tasks
|
This will have to be added as an option to https://github.com/isaacs/path-scurry. If so, it'll be trivial to pass it along from glob. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I should have allowed more time for negative feedback, but eager to get on with my planned refactor in
vinyl-fsI figured I might as well take a stab at proposing something concrete.