Add option to cache lstat results instead of stat #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikkemperman
changed the title
|
No longer relevant in v9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm preparing a PR to vinyl-fs to signifcantly reduce the number of fs operations by leveraging node-glob's caches. However there's a
resolveSymlinksoption which users set to false to obtain stats of the link, rather than the target, for symlink matches.Currently this has us do three stats (an lstat and stat in node-glob, and then another lstat in vinyl-fs). This PR, or something like it, would allow me to reduce that to just one (lstat).
PS I've included a commit from another PR to make Appveyor pass.