feat: add pathsep option #475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas377
commented
May 15, 2022
| @@ -83,6 +83,11 @@ function setopts (self, pattern, options) { | |||
| self.statCache = options.statCache || Object.create(null) | |||
| self.symlinks = options.symlinks || Object.create(null) | |||
|
|
|||
| // avoiding empty strings | |||
| if (!!options.pathsep) { | |||
| pattern = pattern.split(options.pathsep).join("/") | |||
There was a problem hiding this comment.
While using String.prototype.replace with a plain RegExp with the g flag (String.prototype.replaceAll isn't supported on node v12 and v14) is significantly faster than splitting and joining strings, creating a RegExp from dynamic content poses both security risks and can throw incorrect errors when a single backslash is inputted.
Escaping potentially dangerous characters will put a large load on one point security-wise, and is less performant than simply splitting and joining strings.
|
No longer relevant, landed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of the implementation of #468. This PR implements the pathsep option, which is intended to allow users to specify the path separator used in the glob pattern.