fix(types): fetch method should not return void but undefined instead #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thenkei
commented
May 31, 2023
Thenkei
commented
May 31, 2023
|
The test suite is now running correctly locally. |
|
This patch would allow the |
4 tasks
isaacs
pushed a commit
to Thenkei/node-lru-cache
that referenced
this pull request
Jun 6, 2023
PR-URL: isaacs#303 Credit: @Thenkei Close: isaacs#303 Reviewed-by: @isaacs EDIT(@isaacs): edited to continue to allow `fetchMethod` to return `Promise<void>`. BREAKING CHANGE: public method type signature change
isaacs
pushed a commit
to Thenkei/node-lru-cache
that referenced
this pull request
Jun 15, 2023
PR-URL: isaacs#303 Credit: @Thenkei Close: isaacs#303 Reviewed-by: @isaacs EDIT(@isaacs): updated to preserve `fetchMethod`'s ability to return `void`. BREAKING CHANGE: change to public type signature
PR-URL: isaacs#303 Credit: @Thenkei Close: isaacs#303 Reviewed-by: @isaacs EDIT(@isaacs): edited to continue to allow `fetchMethod` to return `Promise<void>`. BREAKING CHANGE: public method type signature change
|
Thank you so much @isaacs. 🙏 I hope it will help other TS users too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to the issue #302