Add a third argument to SAXStream.prototype.end #144
Conversation
Fixes isaacs#143. The end method should accept a third argument that is a callback to call when the stream is finished. http://nodejs.org/api/stream.html#stream_writable_end_chunk_encoding_callback
|
Needs a test. |
|
Didn’t read the contribution guide, now did ya. NO PATCHES WITHOUT A TEST TEST MUST PASS WITH THE PATCH. TEST MUST FAIL WITHOUT THE PATCH. NO EXCEPTIONS. |
|
Well, there is a bug in the library, I reported it and proposed a fix 4 years ago. If you want to add a test, go for it. If you want to keep the bug, keep it. @z3dev : I'm not sure using this kind of language will help. Of course I didn't read the contributor guide, because it did not exist at the time I made this pull request. |
|
@lovasoa Sorry about that... The guidelines are pretty clear, but I didn’t know those didn’t exit back in 2015. My bad. We JSCAD are also a BIG fan of this library. I’m really trying to get a few more owners/contributors added so this library can move forward. It’s already rock solid, so just a few points of maintenance would be easy to manage. |
Fixes #143.
The end method should accept a third argument that is a callback to call when the stream is finished.
http://nodejs.org/api/stream.html#stream_writable_end_chunk_encoding_callback