fix: don't throw on comment in dtd #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the minimum change to allow comments in Doctype declarations, without adding additional support for parsing Doctype entities.
As sax was not checking for comments before, it would interpret
'or]as XML and falsely treat them as real quotes or closing tags despite residing in an XML comment.I don't think compatibility is a major concern for this PR, as the previous behavior was to throw an exception, so XML files that were affected by this weren't supported to begin with.
Regression Tests
I ran the regression test script from #266 on this PR, and can confirm it passes. 👍🏽
Related