Fix require function name in README.md #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable holding the function returned by `createRequire()` is named `req` but the `require` function is being used below, so `require` is undefined here. This fixes that by ensuring that both variable names are the same. PR-URL: isaacs#64 Credit: @RaisinTen Close: isaacs#64 Reviewed-by: @isaacs
isaacs
force-pushed
the
fix-require-function-name-in-readme
branch
from
0883cc0
to
2d0813d
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable holding the function returned by
createRequire()is namedreqbut therequirefunction is being used below, sorequireis undefined here. This fixes that by ensuring that both variable names are the same.