Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BigFix Relevance #744

Closed
wants to merge 2 commits into from

Conversation

briangreenery
Copy link

No description provided.

@isagalaev
Copy link
Member

Hey @briangreenery! What was the reason to close this pull request?

@briangreenery
Copy link
Author

This language is probably not generally useful. It's also easy to add it to highlight.js as an addon, and I created hljs-bigfix-relevance to do this. Also, the pull-request was open for a while, so I thought maybe there wasn't any interest in including it (which is okay!)

@jgstew
Copy link

jgstew commented Mar 25, 2015

If possible, it would be useful to see this in highlight.js but the add on functionality might be sufficient since bigfix relevance is so specific to a particular application.

@isagalaev
Copy link
Member

@briangreenery sorry, we, frankly, suck at reacting fast on new contributions :-( But I believe you're right and it's better to keep it as an add-on. I'm trying to figure out what to do with proliferation of highly specialized and niche languages in highlight.js that bump the overall number and add bulk but not much value for most users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants