Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings #60

Closed
george-gw opened this issue Jun 13, 2016 · 3 comments
Closed

Warnings #60

george-gw opened this issue Jun 13, 2016 · 3 comments

Comments

@george-gw
Copy link

george-gw commented Jun 13, 2016

I got the following warnings:

Conversion.swift:137:42: cast from 'NSDictionary?' to unrelated type '[T : AnyObject]' always fails
if let elements = rhs as? NSDictionary as? [T : AnyObject] {
                    ~~~~~~~~~~~~~~~~~~~~ ^   ~~~~~~~~~~~~~~~

Deserialization.swift:122:42: cast from 'NSDictionary?' to unrelated type '[T : AnyObject]' always fails
if let elements = rhs as? NSDictionary as? [T : AnyObject] {
                    ~~~~~~~~~~~~~~~~~~~~ ^   ~~~~~~~~~~~~~~~

┆Issue is synchronized with this Asana task

@isair
Copy link
Owner

isair commented Jun 13, 2016

Tests for the methods with these warnings pass. If you run into any buggy behavior concerning dictionary conversion, submit an example code snippet and I'll rename and reopen this issue.

@isair isair closed this as completed Jun 13, 2016
@george-gw
Copy link
Author

I haven't actually had problems with the code, it's just that I came across these warnings and I thought I'd let you know about them.

Either way, thank you for sharing the library :)

@isair
Copy link
Owner

isair commented Jun 14, 2016

You're welcome, glad you're not having issues.

On Mon, Jun 13, 2016 at 5:40 AM, george-gw notifications@github.com wrote:

I haven't actually had problems with the code, it's just that I came
across these warnings and I thought I'd let you know about them.

Either way, thank you for sharing the library :)


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AA8UNZoIVVeywj1lQmFtExzVWxqa_8qaks5qLU_FgaJpZM4I0GZj
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants