samplingSite location is "location", curation location is "curation_location" #308

dannymandel · 2023-09-06T21:06:37Z

We are handling the "location" key inconsistently when it occurs inside subdictionaries in a document.

For example, in sampling_site:

        "samplingSite": {
            "description": "Depth to bottom 4.57 m",
            "label": "San Pedro Bay, breakwater",
            "location": {

https://github.com/isamplesorg/metadata/blob/264a71947b05cdb3a7ffad8303be43039a681ea6/examples/GEOME/test1.0Valid/ark-21547-DRW2LACM-DISCO-16924-v1.json#L88

but in curation:

    "curation": {
        "label": "",
        "description": "fixative: 95% ethanol; preservative: 95% ethanol; record modifiedBy: Mike O'Mahoney; modifiedReason: updated tissueID from 9013 to corrected value 9597 (19Aug20); sample identified: 2019-09-02; ",
        "access_constraints": [],
        "curation_location": "",

https://github.com/isamplesorg/metadata/blob/264a71947b05cdb3a7ffad8303be43039a681ea6/examples/GEOME/test1.0Valid/ark-21547-DRW2LACM-DISCO-16924-v1.json#L107C10-L107C27

Granted, one is a dictionary and one is a string, but it seems strange that the keys are different.

The text was updated successfully, but these errors were encountered:

smrgeoinfo · 2023-09-08T22:38:23Z

lets make them consistent and make sampling_site/location to be sampling_site/sample_location

smrgeoinfo · 2023-09-08T22:46:22Z

fixed see isamplesorg/metadata#160

* Checkpoint on new OpenContext record format/refactoring to constants * Simple facade around the controlled vocabularies * Add term lookup by label as well * Extract the Getty keywords from the OpenContext JSON * More constants * Last few constants * Fix a couple missing imports * Running the new code and model through a unit test * Route existing controlled vocabulary rules through new vocabulary mapper classes * Fixes for #307 #308 * Get GEOME integrated into the new format * Get Smithsonian adapted to the new format * Update Smithsonian to new format * Fix id_string in case the citation uri doesn't start with https * A couple fixes for the new controlled vocabulary format * Annotated a couple of lines with an issue that needs fixing * Utilize the fields in the new OpenContext API * Wrote up the has_context_categories question in an issue, and made the code refer to that issue * Fixes for #310 * Update tests to new formats, fix issues discovered while testing live objects * Update tests to new format * flake8 * mypy fixes * Include the prefix in the vocabulary terms -- we need them and the predictive models return it * Add ability to regenerate test output files * Regenerate test files, fix a bug with key name in GEOMETransformer * Update the solr indexer to work properly with the new formats * Add comments indicating something is amiss here * Fix bug around OpenContext names * Fix GEOME placeNames bug * flake8 * Fix mypy * Add a test to make sure all the generated files parse as valid solr docs, also delete a few unused files

dannymandel assigned smrgeoinfo and datadavev Sep 6, 2023

smrgeoinfo mentioned this issue Sep 8, 2023

samplingSite location is "location", curation location is "curation_location" isamplesorg/metadata#160

Closed

dannymandel added a commit that referenced this issue Sep 20, 2023

Fixes for #307 #308

dbd77aa

dannymandel closed this as completed Sep 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

samplingSite location is "location", curation location is "curation_location" #308

samplingSite location is "location", curation location is "curation_location" #308

dannymandel commented Sep 6, 2023

smrgeoinfo commented Sep 8, 2023

smrgeoinfo commented Sep 8, 2023 •

edited

samplingSite location is "location", curation location is "curation_location" #308

samplingSite location is "location", curation location is "curation_location" #308

Comments

dannymandel commented Sep 6, 2023

smrgeoinfo commented Sep 8, 2023

smrgeoinfo commented Sep 8, 2023 • edited

smrgeoinfo commented Sep 8, 2023 •

edited