Don't loose track of box objects if init crashes #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdavidrees
pushed a commit
to mrdavidrees/hive
that referenced
this pull request
Jan 16, 2022
Ensure HiveLists are treated as non-nullable in hive_generator (isar#728) * Replaced ?. operator with . operator Resolves error "The argument type 'HiveList<T>?' can't be assigned to the parameter type 'HiveList<T>'. Closes issue isar#664. * Ensuring nullable HiveLists are properly generated Co-authored-by: Misir Jafarov <misir.ceferov@gmail.com> Updated hive_generator dependencies (isar#765) * Updated dependencies * Changed version dependencies Bump up hive_generator to v1.1.1 Get indexDB selectively based on window property (isar#802) Co-authored-by: Wenhao Wu <wenhao.wu@signanthealth.com> Add missing path parameter to HiveInterface methods (isar#776) Fixes broken CI (isar#806) * Update pubspec.yaml * Migrated from mockito to mocktail * Test on dart 2.14 Don't loose track of box objects if init crashes (isar#846) feat: Add flush method to boxes (isar#852) bump: Update to v2.0.5 Updated hive_generator analyzer dependency (isar#858) bump up hive_generator to v1.1.2 Change pedantic to linter and fix warnings (isar#876)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Box.openBox raises an exception to due being corrupt or having an unknown type, the reference to the open file is dropped. The result of this is that on Windows, it is not possible to delete the corrupted box as .close() can't be called so Windows thinks the file is still in use.
This saves the reference to the open file before calling initialize() rather than afterwards.