Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify title and short title fields in publication content item - 3 #399

Closed
paregorios opened this issue Sep 12, 2019 · 5 comments
Closed

Comments

@paregorios
Copy link
Member

paregorios commented Sep 12, 2019

In the add/edit form for the publication content item, please make the following changes:

  1. Relabel the legacy "Title" field "Short Title".
  2. Change the long description for this "Short Title" field to read: "The short title of the publication".
  3. Ensure that this "Short Title" field is used for plone id (url slug) creation (it currently is).
  4. Relabel the legacy "Short Title" field as "Full Title".
  5. Add a long description for this "Full Title" field to read: "The full bibliographic title of the publication".
  6. Keep "full Title" a plain text field, but make it permissible to add HTML tags that gets parse into the document content when rendering the base view.
  7. On Zotero fetch:
    • put the Zotero Title in the Publication "Full Title" field
    • put the Zotero Short Title in the Publication "Short Title" field

In the base view for the publication content item:

  1. Suppress display of the "short title" field entirely.
  2. Display the "full title" field as if it is the object title (i.e., H1).
  3. Do not display the long description for either field in the base view.
@paregorios paregorios added this to the August 2019 milestone Sep 12, 2019
@paregorios paregorios changed the title Modify title and short title fields in publication content item Modify title and short title fields in publication content item - 3 Sep 12, 2019
@jessesnyder jessesnyder self-assigned this Sep 12, 2019
@jessesnyder
Copy link

@paregorios Wrote a migration for Publications and ran it on staging along with other changes, so ready to test.

@paregorios
Copy link
Member Author

These bits are spiffy:

  • Labeling on the add/edit form of the two title-esque fields is the way I wanted.
  • On the base view, the "full title" is shown and the "short title" is not, which is great.
  • The field descriptions are working as desired.

Something is still not quite right with the fetch from Zotero...

I see we also have a knock-on concern for the "publications listing". The "full title" for the subordinate content items should be used, rather than the (short) title.

@jessesnyder
Copy link

jessesnyder commented Sep 13, 2019

Something is still not quite right with the fetch from Zotero...

@paregorios Works for me. Try a hard refresh when you first load the add form(?)

@jessesnyder
Copy link

I see we also have a knock-on concern for the "publications listing". The "full title" for the subordinate content items should be used, rather than the (short) title.

Fixed!

@paregorios
Copy link
Member Author

Both fixes are fixed! Please merge to master and deploy to production!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants