Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support IREE as a TF backend #45

Merged
merged 15 commits into from
Sep 13, 2022
Merged

support IREE as a TF backend #45

merged 15 commits into from
Sep 13, 2022

Conversation

Co1lin
Copy link
Collaborator

@Co1lin Co1lin commented Sep 13, 2022

No description provided.

@Co1lin Co1lin requested a review from ganler September 13, 2022 01:28
ganler
ganler reviewed Sep 13, 2022
View reviewed changes
Copy link
Member

@ganler ganler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we just need to have more rigorous checking in creating backend factories. BTW, you can add a new row in the README regarding the alpha support for iree. I will test the branch myself and bring more detailed suggestions later. Thanks!!!

nnsmith/backends/iree.py Outdated Show resolved Hide resolved
nnsmith/backends/iree.py Outdated Show resolved Hide resolved
nnsmith/backends/iree.py Outdated Show resolved Hide resolved
nnsmith/backends/iree.py Outdated Show resolved Hide resolved
nnsmith/backends/iree.py Outdated Show resolved Hide resolved
tests/tensorflow/test_iree_backend.py Outdated Show resolved Hide resolved
@Co1lin Co1lin requested a review from ganler September 13, 2022 04:56
ganler
ganler reviewed Sep 13, 2022
View reviewed changes
Copy link
Member

@ganler ganler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the instant update. Let's work a bit more to well-form the optmax and device argument. After that, I will add a refactor patch to migrate device => target.

nnsmith/backends/iree.py Outdated Show resolved Hide resolved
@ganler ganler mentioned this pull request Sep 13, 2022
Closed
21 tasks
@ganler ganler merged commit bcca57f into main Sep 13, 2022
@ganler ganler deleted the iree branch September 13, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganler ganler ganler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Co1lin @ganler