Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let users pick whatever font they want. #1897

Closed
wants to merge 1 commit into from
Closed

Let users pick whatever font they want. #1897

wants to merge 1 commit into from

Conversation

davemackintosh
Copy link

@davemackintosh davemackintosh commented Sep 4, 2022

I'm not convinced this limitation does any good or fixes any issues.

Should close #1579 #1483

I'm not convinced this limitation does any good or causes any issues.
@davemackintosh davemackintosh marked this pull request as draft September 6, 2022 08:49
@davemackintosh
Copy link
Author

davemackintosh commented Sep 6, 2022

So, when I patched the font I wanted to use I forgot to specify the -s flag which is why I was seeing issues with alignment in #1901. The correct command to patch a font and keep correct column alignment and glyph width is

docker run --rm -v ~/Downloads/cozette:/in -v ~/Downloads/patched-fonts:/out nerdfonts/patcher --complete -s

However, even when it is specifically marked as mono it still does not appear in the font selector which means I'll leave this PR open.

@davemackintosh davemackintosh marked this pull request as ready for review September 6, 2022 10:36
@davemackintosh
Copy link
Author

image

@davemackintosh
Copy link
Author

image

@davemackintosh davemackintosh closed this by deleting the head repository Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All other fonts do not render
1 participant