Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Update README.md #1

merged 3 commits into from
Aug 22, 2023

Conversation

ishaan812
Copy link
Owner

No description provided.

README.md Outdated
@@ -10,4 +11,31 @@ The project will consist of developing an open-source API that allows you to pas
- Octokit.JS
- Jest

## Dev Runbook
Dependancies: NodeJS, npm, GithubAPIKey

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which node version. Add links on how to get a github api key

6. Now the nodejs server should be running! To test it just go to `localhost:{{PORT}}` and the text `TypeScript With Express` should be returned.

## Setting up ElasticSearch Runbook (Dev/Local)
-**docker pull docker.elastic.co/elasticsearch/elasticsearch:8.8.2**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a docker compose file or a bash script with that does all this setup

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do added to backlog.


## API Endpoints
[![Run in Postman](https://run.pstmn.io/button.svg)](https://app.getpostman.com/run-collection/19841716-f1801bb7-b189-429b-a875-91b115d349a2?action=collection%2Ffork&source=rip_markdown&collection-url=entityId%3D19841716-f1801bb7-b189-429b-a875-91b115d349a2%26entityType%3Dcollection%26workspaceId%3D5ebe19fb-61d4-47a7-9cae-de3834853f6b)
- **/search?prompt={{prompt}}** : The active search endpoint. Add the search prompt in the prompt variable in query params.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What method i.e verb? Also given you have a postman collection why is this even required?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, just wanted to offer an alternative

@ishaan812 ishaan812 merged commit 0553512 into main Aug 22, 2023
1 check failed
@ishaan812 ishaan812 deleted the ishaan812-README-Update-patch-1-1 branch August 22, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants