Skip to content

Commit

Permalink
Move feature:etcd-wrapper from alpha to beta feature. (gardener#744)
Browse files Browse the repository at this point in the history
* Move feature:etcd-wrapper from alpha to beta feature.

* Address review comments.

* Adjusted the skafold activation profile with use-feature-gates to do-not-use-feature-gates.
  • Loading branch information
ishan16696 committed Jan 8, 2024
1 parent 83c84c7 commit 9f71c2b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
3 changes: 2 additions & 1 deletion docs/deployment/feature-gates.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ The following tables are a summary of the feature gates that you can set on etcd

| Feature | Default | Stage | Since | Until |
|------------------|---------|---------|--------|-------|
| `UseEtcdWrapper` | `false` | `Alpha` | `0.19` | |
| `UseEtcdWrapper` | `false` | `Alpha` | `0.19` | `0.21`|
| `UseEtcdWrapper` | `true` | `Beta` | `0.22` | |

## Feature Gates for Graduated or Deprecated Features

Expand Down
3 changes: 2 additions & 1 deletion pkg/features/features.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,12 @@ const (
// changes required for the usage of the etcd-wrapper image.
// owner @unmarshall @aaronfern
// alpha: v0.19
// beta: v0.22
UseEtcdWrapper featuregate.Feature = "UseEtcdWrapper"
)

var defaultFeatures = map[featuregate.Feature]featuregate.FeatureSpec{
UseEtcdWrapper: {Default: false, PreRelease: featuregate.Alpha},
UseEtcdWrapper: {Default: true, PreRelease: featuregate.Beta},
}

// GetDefaultFeatures returns the default feature gates known to etcd-druid.
Expand Down
6 changes: 3 additions & 3 deletions skaffold.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ deploy:
eventsThreshold: 15
metricsScrapeWaitDuration: "30s"
profiles:
- name: use-feature-gates
- name: do-not-use-feature-gates
activation:
- env: "USE_ETCD_DRUID_FEATURE_GATES=true"
- env: "USE_ETCD_DRUID_FEATURE_GATES=false"
patches:
- op: add
path: /deploy/helm/releases/0/setValues/featureGates
value:
UseEtcdWrapper: true
UseEtcdWrapper: false
---
apiVersion: skaffold/v2beta25
kind: Config
Expand Down

0 comments on commit 9f71c2b

Please sign in to comment.