Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

red brackets #33

Open
xuxinx opened this issue Nov 22, 2021 · 3 comments
Open

red brackets #33

xuxinx opened this issue Nov 22, 2021 · 3 comments

Comments

@xuxinx
Copy link

xuxinx commented Nov 22, 2021

Screen Shot 2021-11-22 at 10 59 03

Screen Shot 2021-11-22 at 10 46 03

all brackets are red: ( [ {
and: !, ,, some golang keywords, etc..

red means error, right?
I don’t know if I have misconfigured something. but without vim.cmd('colorscheme solarized-flat'), the color looks correct(?)
Screen Shot 2021-11-22 at 11 05 32
@xuxinx
Copy link
Author

xuxinx commented Nov 22, 2021

btw, the background color of git signs(from https://github.com/lewis6991/gitsigns.nvim) is wired

@chrs8
Copy link
Contributor

chrs8 commented Jan 2, 2022

Same issue here. The "problem" is the mapping of the treesitter elements "TSPunctDelimiter" and "TSPunctBracket" to "Delimiter", which in turn is mapped to "Special" (orange color, not red btw). I don't know if it's intended that way.
Changing the mapping to "Normal" looks much better IMHO.

luator added a commit to luator/nvim-solarized-lua that referenced this issue Jan 18, 2022
@luator
Map Delimiter to Normal instead of Special
16ccde4 
Resolves ishan9299#33
@luator luator mentioned this issue Jan 18, 2022
Closed
@luator
Copy link
Contributor

luator commented Jan 18, 2022

I created a PR proposing the change: #39.

luator added a commit to luator/nvim-solarized-lua that referenced this issue Feb 16, 2022
@luator
Add option to disable special delimiter highlighting
563ba4f 
Add an option `solarized_highlight_delimiters` through which it can be
controlled whether the `Delimiter` group is linked to `Special` or
`Normal`.

By default it is enabled (resulting in `Delimiter = Special`) thus
preserving the current behaviour.

Resolves ishan9299#33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Map Delimiter to Normal instead of Special luator/nvim-solarized-lua
3 participants
@luator @xuxinx @chrs8