Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styled font weight and response box #25

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Solance
Copy link

@Solance Solance commented Mar 22, 2022

Changed the response box style to be the same as in the English version.
Changed the fonts weight - numbers and English letters are closer to Hebrew letters.

static/css/style.css Show resolved Hide resolved
border: 1px solid #716f6f;
padding-right: 20px;
padding-left: 5px;
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what it looks like - I'm not sure the italic+bold looks good on the Hebrew text, also not sure about the color (though I do like the dark mode color). Wdyt?

image

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(any ideas on how to make the design cleaner?)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my machine (different browsers) it looks different, only italic.

Screenshot 2022-03-22 at 22 40 52

The color is the same one as in the English version, but I will try to think of a better one, as well as some cleaner design (I'm a bit limited here but will try!).

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now there's no background in light-mode
image

static/css/style.css Show resolved Hide resolved
@@ -2,9 +2,9 @@ body, input {
font-size: 17px;
line-height: 27px;
-webkit-font-smoothing: subpixel-antialiased;
font-family:-apple-system-font, BlinkMacSystemFont, 'Helvetica Neue', sans-serif;
font-family:-apple-system, BlinkMacSystemFont, avenir next, avenir, segoe ui, helvetica neue, helvetica, Ubuntu, roboto, noto, arial, sans-serif;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually like the current font better (at least on mac) - current:
image

new:
image

Also, line spacing in the paragraph is a bit too large + font size is too small

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the colors and the design of the "guess" button + textbox!

@Solance
Copy link
Author

Solance commented Mar 29, 2022

I fixed the response box background in light mode. I actually considered removing it, that's why it was missing. But I added it again, with a slight different color. I'm afraid I can't do more than that given the limitations I have.

A small side note: Noticed you added the 'buy me coffee' paragraph, I think it'll look better to add it right after the לשתף ולחזור לשחק מחר'. The left alignment is a bit messy and confusing and having it as a separate paragraph is a bit too much with the timer. These are my 2 cents about it :P

@Solance
Copy link
Author

Solance commented Apr 16, 2022

Is there anything more I should do/change then? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants