enhance method _get_repo_name_from_url to handle case when .git is part of the repo name #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt of the repo name
This reverts commit f069e69.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #240 +/- ##
=======================================
Coverage 98.08% 98.09%
=======================================
Files 14 14
Lines 1046 1048 +2
=======================================
+ Hits 1026 1028 +2
Misses 20 20
|
|
Can you add a couple of tests for this function? I think there are already some tests written, you can simply add a couple of new ones with |
|
Tests added @ishepard, let me know if it's OK with you, not very confident with where I placed the tests :D |
|
hmm, not sure why the check on windows-latest is failed yet |
|
ok now it's passed 🤯 |
|
Yeah not your fault, windows is a bit flaky 😄 thanks for the PR!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #236