Add ListenSCTPExt & DailSCTPExt to pass InitOptions; fixes for IPv6 & local port bind support #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Fix to avoid returning negative read lenth on failed SCTP Reads (it breaks std Go buffered IO) 2) Atomic access to internal SCTP Connection fd & connection close FD cleanup to prevent "double" fd closure which may affect another connection in multithreaded environments.
1) Fix to avoid returning negative read lenth on failed SCTP Reads (it breaks std Go buffered IO) 2) Atomic access to internal SCTP Connection fd & connection close FD cleanup to prevent "double" fd closure which may affect another connection in multithreaded environments.
|
@emakeev Thank you for the fix. Could you fix the conflicts? |
sctp_linux.go
Outdated
| @@ -128,8 +128,13 @@ func ListenSCTPExt(network string, laddr *SCTPAddr, options InitMsg) (*SCTPListe | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| if err = setDefaultSockopts(sock, af, ipv6only); err != nil { | |||
| syscall.Close(sock) | |||
There was a problem hiding this comment.
@emakeev How about using defer ?
|
switched ListenSCTPExt & DailSCTPExt cleanup to use defer. Don't see any merge conflicts on my side... |
|
@emakeev This project uses rebase and merge manner to merge PRs. Please rebase your branch on the current master |
|
sorry, I cannot resolve conflicts, I do not see. my remote was rebased to master. I'll create new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.