Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error status code #48

Closed
dccarmo opened this issue Jun 9, 2015 · 3 comments
Closed

Error status code #48

dccarmo opened this issue Jun 9, 2015 · 3 comments

Comments

@dccarmo
Copy link

dccarmo commented Jun 9, 2015

It'd be great if API.responseErrorFromObject(object:) returned a NSHTTPURLResponse - it'd help to validate HTTP status codes.
@dccarmo
Copy link
Author

dccarmo commented Jun 9, 2015

Or maybe return the status code.

@ishkawa
Copy link
Owner

ishkawa commented Jun 11, 2015

Yes, we will add NSHTTPURLResponse to the arguments of responseErrorFromObject(_:).

@ishkawa ishkawa mentioned this issue Jun 12, 2015
Closed
@ishkawa
Copy link
Owner

ishkawa commented Jul 30, 2015

NSHTTPURLResponse is now available in Request.responseFromObject(_:URLResponse:)!

APIKit/APIKit/Request.swift

Line 39 in a5c6faf

func responseFromObject(object: AnyObject, URLResponse: NSHTTPURLResponse) -> Response?

@ishkawa ishkawa closed this as completed Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dccarmo @ishkawa