Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set titlebar text color to terminal text color #31

Closed
wants to merge 2 commits into from
Closed

Set titlebar text color to terminal text color #31

wants to merge 2 commits into from

Conversation

alex47
Copy link
Contributor

@alex47 alex47 commented Jul 17, 2018

Before:
Before

After:
After

@trmdi
Copy link
Contributor

trmdi commented Jul 18, 2018

Cool. It should be like that.

@trmdi
Copy link
Contributor

trmdi commented Jul 18, 2018 •
edited
Loading

Found a bug: the Application Menu icon isn't set to the right color, or it misses the circle background.

image

@ishovkun @alex47

@alex47
Copy link
Contributor Author

alex47 commented Jul 18, 2018

@trmdi that bug is not related to the titlebar text color
I think you should rather open an issue for that

@trmdi
Copy link
Contributor

trmdi commented Jul 18, 2018 •
edited
Loading

@ishovkun @alex47

I don't know if that button without the circle backgound is his intention or not.

  • If it is, then this is your bug, so I post here. It's not the text, but it's related to the titlebar background color.
  • If not, I will open a new issue.

@alex47 alex47 mentioned this pull request Aug 20, 2018
Closed
@ishovkun
Copy link
Owner

Sorry for being absent for so long. Github tells me that there are conflicts for this pull request. Please resolve them.

@alex47
Copy link
Contributor Author

alex47 commented Aug 23, 2018

superseded by #32

@alex47 alex47 closed this Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alex47 @trmdi @ishovkun