Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zlib/jpeg/png/... auto link to native libraries on Ubuntu/OSX #1

Closed
qianyizh opened this issue Dec 20, 2016 · 3 comments
Closed
Assignees

Comments

@qianyizh
Copy link
Collaborator

On Windows, all packages are included in External, and linked with Open3D.
On Ubuntu/OSX, this should be done automatically with native libraries.
This should be done with findpackage in CMake.

Roadblock: Need to do it and thoroughly test if these dependencies (a weird version, e.g.) break Open3D. In that case, we should fall back to the code included in External.

@qianyizh
Copy link
Collaborator Author

Starting to work on this issue from e6ae72c

@qianyizh
Copy link
Collaborator Author

A series of commits have addressed the issue.
From e6ae72c to 861c5de, the following libraries have two configurations:

  • Eigen
  • Glew
  • Glfw
  • libjpeg
  • libpng
  • jsoncpp

A few libraries that have not changed:

  • flann (header only, old and stable)
  • liblzf (old and stable)
  • rply (old and stable)
  • tinyfiledialog (experimental)
  • pybind11 (experimental)
  • librealsense (should be auto-configured, did not get time to do it)

Moving the priority to low. I will revisit it in the future when librealsense is more stable.

@qianyizh
Copy link
Collaborator Author

qianyizh commented Dec 4, 2017

Close for now.

@qianyizh qianyizh closed this as completed Dec 4, 2017
qianyizh pushed a commit that referenced this issue Feb 27, 2018
@NKKD NKKD mentioned this issue Sep 22, 2020
yxlao added a commit that referenced this issue Dec 10, 2020
Adaptive anchor point support via sparse Eigen matrix

Camera selection based on vertex normal (#2)

* mac compatibility

* pass in max_visable_cameras

* argmax_k

* initial get camera center

* select 3 best cameras

* fix init vector

* print viscnt

* fix visible typo

* add mesh filter structure

* implements FilterTriangleMesh not compiling

* FilterTriangleMesh compiles

* default filter strength

* bind enum types

* python binding filter_triangle_mesh

* fix filter type check

* fix vector init segfault

* working

* working

* add question

* add box smooth filter, not using filter_strength yet

* comments

* implement vill invisible vertex colors

* better print

* color visibility map based on colors

* do not constrain max_visible_cameras_ to get actual camera count

* actually use max_visible_cameras

* introduce min_visible_cameras

* erode with abs value

* print info when sparse matrix insert

* try catch block for eigen debug

* fix zero index crashing problem

* remove prints and re-enable openmp

* remove empty lines

* disable print

* disable color injection

* disable visibility count mesh creation

fix index (#3)

skip if adaptive anchor cannot see any vertex (#4)

Colormap memory optimized (#5)

* remove dummy code

* CreateDepthBoundaryMasks with images_rgbd

* SetGeometryColorAverage use rgbd

* CreateVertexAndImageVisibility uses rgbd image

* remove all images_color and images_depth

* remove dummy code
heethesh added a commit to heethesh/Open3D that referenced this issue Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant