Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 style #112

Merged
merged 7 commits into from
Dec 8, 2017
Merged

PEP8 style #112

merged 7 commits into from
Dec 8, 2017

Conversation

syncle
Copy link
Contributor

@syncle syncle commented Dec 7, 2017

Changing python function names to comply with PEP8 style.

Copy link
Collaborator

@qianyizh qianyizh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two minor comments.

One additional thing:
Can we add a simple license note at the beginning of each py file, something like:

# Open3D: www.open3d.org
# The MIT License (MIT)
# See license file or visit www.open3d.org for details

@@ -59,7 +59,7 @@ void pybind_camera(py::module &m)
.def("__repr__", [](const PinholeCameraIntrinsic &c) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 		.def_readonly_static("PrimeSenseDefault",
 				&PinholeCameraIntrinsic::PrimeSenseDefault)

This should also be changed to the same naming convention. See this:
https://www.python.org/dev/peps/pep-0008/#method-names-and-instance-variables

@@ -225,17 +225,17 @@ void pybind_globaloptimization(py::module &m)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


 	py::class_<GlobalOptimizationLevenbergMarquardt,
 			PyGlobalOptimizationMethod<GlobalOptimizationLevenbergMarquardt>,
 			GlobalOptimizationMethod> global_optimization_method_LM(m,
 			"GlobalOptimizationLevenbergMarquardt");
 	py::detail::bind_default_constructor<GlobalOptimizationLevenbergMarquardt>
 			(global_optimization_method_LM);
 	py::detail::bind_copy_functions<GlobalOptimizationLevenbergMarquardt>(
 			global_optimization_method_LM);
 	global_optimization_method_LM
 			.def("__repr__", [](const GlobalOptimizationLevenbergMarquardt &te) {
 			return std::string("GlobalOptimizationLevenbergMarquardt");
 	});

LM -> lm

This was referenced Dec 7, 2017
@qianyizh qianyizh merged commit b58fef9 into isl-org:master Dec 8, 2017
@qianyizh qianyizh deleted the pep8_style branch December 8, 2017 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants