Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'depth_diff_max' to 'max_depth_diff' #5219

Closed
wants to merge 1 commit into from
Closed

Change 'depth_diff_max' to 'max_depth_diff' #5219

wants to merge 1 commit into from

Conversation

Techassi
Copy link

@Techassi Techassi commented Jun 19, 2022

When using the reconstruction system located in examples/python/reconstruction_system the first step Make fragments failes to run. I tested the latest version of the master branch (c43eabe).

python run_system.py --config ./config/tutorial.json --make

After fixing the error

AttributeError: 'open3d.cpu.pybind.pipelines.odometry.OdometryOption' object has no attribute 'depth_diff_max'

with the in this PR provided change, the script ran without any issues.

It seems like the commit c8f8f40 has introduced this change in the C++ source.


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Jun 19, 2022

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@yuecideng
Copy link
Collaborator

yuecideng commented Jun 20, 2022

If you want to use the latest master of open3d, please download the latest python package or build open3d from source. Otherwise you should use the latest release 0.15.1 branch to run the example. @Techassi

Update: the master branch wheel link has been updated to: http://www.open3d.org/docs/latest/getting_started.html#pip-pypi

@yxlao
Copy link
Collaborator

yxlao commented Jun 21, 2022

Thanks @Techassi . This has been addressed in #5167.

If you are using the example code from mater, you may compile from source, or download the master wheel from http://www.open3d.org/docs/latest/getting_started.html#pip-pypi

@yxlao yxlao closed this Jun 21, 2022
@Techassi
Copy link
Author

Okay thx. Good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants