Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support msgpack versions without cmake #5624

Merged
merged 4 commits into from Dec 2, 2022
Merged

Support msgpack versions without cmake #5624

merged 4 commits into from Dec 2, 2022

Conversation

cielavenir
Copy link
Contributor

@cielavenir cielavenir commented Oct 27, 2022 •
edited by germanros1987

This change is Reviewable

benjaminum
benjaminum approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @cielavenir)

@germanros1987 germanros1987 merged commit 9ca1c11 into isl-org:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminum benjaminum benjaminum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cielavenir @benjaminum @germanros1987