Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve ISS keypoint #6079

Merged
merged 4 commits into from Jun 30, 2023
Merged

Fix and improve ISS keypoint #6079

merged 4 commits into from Jun 30, 2023

Conversation

DNKpp
Copy link
Contributor

@DNKpp DNKpp commented Apr 14, 2023

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes Bug with compute_iss_keypoints (failing randomly) #4847
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

During my usage of the ISS Keypoint functionality I encountered some random crashes, which I tried to find the reason for. I explained it here: #4847 (comment)

Secondly there seems to be a more subtile issue in ComputeModelResolution, as the original code only checks for "more than 0" neighbors, but as the query point itself will always be present, this condition will never fail. I adjusted the condition here to >= 2.

Eventually I applied some std algorithms instead of manually written loops, which makes the intent of the code more obvious.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
    Yes, but it crashes due to some strange errors. But resharper is applying the clang-format file anyways.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

This is the error popup
image

Those are some of the entries of kp_indices
image


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Apr 14, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@DNKpp DNKpp changed the title Improve iss keypoint Fix and improve ISS keypoint Apr 14, 2023
@ssheorey ssheorey requested a review from benjaminum June 1, 2023 17:54
@ssheorey ssheorey closed this Jun 8, 2023
@ssheorey ssheorey reopened this Jun 8, 2023
@ssheorey
Copy link
Member

@benjaminum Is this PR ready to merge? We can ignore the Ubuntu wheel CI failure for now.

@benjaminum
Copy link
Contributor

yes, please merge

@ssheorey ssheorey merged commit 0d772b8 into isl-org:master Jun 30, 2023
35 of 36 checks passed
@DNKpp DNKpp deleted the ImproveISSKeypoint branch July 1, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with compute_iss_keypoints (failing randomly)
3 participants