Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save triangle material IDs and uvs during TriangleMesh::SelectByIndex. #6099

Merged
merged 1 commit into from Jul 25, 2023

Conversation

hanseuljun
Copy link
Contributor

@hanseuljun hanseuljun commented Apr 20, 2023

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

TriangleMesh::SelectByIndex was not copying material IDs and uv information to its output. This lack of information causes an issue when trying to render the output mesh.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Apr 20, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey
Copy link
Member

ssheorey commented Jun 1, 2023

Thanks @hanseuljun for these updates!

@ssheorey ssheorey closed this Jun 8, 2023
@ssheorey ssheorey reopened this Jun 8, 2023
@ssheorey
Copy link
Member

Hi @hanseuljun please fix the code style so that we can merge this PR:

[] I have run python util/check_style.py --apply to apply Open3D code style
to my code.

You can also use make apply-style.

@ssheorey ssheorey self-assigned this Jun 12, 2023
@ssheorey
Copy link
Member

ssheorey commented Jul 7, 2023

Hi @hanseuljun can you take a look and update this PR? Else, you can select Allow edits from maintainers.

@hanseuljun
Copy link
Contributor Author

Sorry for a late reply...
Would it be possible to just pass this without the style check? PR is small and I've tried to keep the style exact. I remember the style check had version conflicts, which I thought would take long to fix so I've skipped. Instead I've tried hard to do style checking with my eyes.

And "allow edits from maintainers" does not work for repos from other orgs...
https://github.com/orgs/community/discussions/5634

@ssheorey
Copy link
Member

Thanks @hanseuljun. Will fix style in next maintenance PR.

@ssheorey ssheorey merged commit ff6fa56 into isl-org:master Jul 25, 2023
34 of 36 checks passed
@hanseuljun
Copy link
Contributor Author

Thanks for the understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants