Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated make conda-package #618

Merged
merged 3 commits into from
Oct 25, 2018
Merged

Automated make conda-package #618

merged 3 commits into from
Oct 25, 2018

Conversation

yxlao
Copy link
Collaborator

@yxlao yxlao commented Oct 17, 2018

Changes

  1. Added make conda-package. Tested on Ubuntu, Mac and Windows.
  2. Renamed pip package creation targets for consistency.

Summary of usage

In summary, we now have:

# C++ make
make                     # our regular make, creates build/lib/Python/open3d.so
make install             # does not install any python module

# python
make python-package      # creates python package in build/lib/python_package

# pip
make pip-package         # creates wheel in build/lib/python_package/pip_pacakge
make install-pip-package # installs wheel in virtualenv
make all-pip-packages    # creates all wheels in PyPI: "open3d-python, py3d, ..."

# conda
# Note 1: only use it when you're inside a conda virtualenv. You might need to 
# re-run cmake to pick up the conda version of python. 
# Note 2: we don't provide `make install-conda-package` similar to pip. This
# is becuase:
#     1) `make install-pip-whell` works in conda environment for local build
#     2) `make conda-package` is mainly for internal use to distribute conda
make conda-pacakge       # creates wheel in build/lib/python_package/conda_pacakge

Motivation

This is a follow up to the automated pip wheel creation PR: #604

The motivation is to automate pip and conda package creation. This is necessary since now the python build process is more complicated (including compiled module, non-compiled module, and later Jupyter plugin with compiled JavaScripts).


This change is Reviewable

Copy link
Contributor

@syncle syncle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me. Do we also need to update docs/compilation.rst or docs/getting_started.rst as well?

Reviewed 15 of 15 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @takanokage and @qianyizh)

Copy link
Collaborator Author

@yxlao yxlao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. There are some additional changes related to Jupyter build steps, will update documents together. See: https://app.asana.com/0/765248819131361/869087443939072

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @takanokage and @qianyizh)

@qianyizh
Copy link
Collaborator

This is great... Need to be highlighted in next release. @germanros1987

@qianyizh qianyizh merged commit 7ed797e into isl-org:master Oct 25, 2018
@yxlao yxlao deleted the conda-install branch March 5, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants