-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build system improvements backported from Debian #6180
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
Hi @roehling can you provide the logs for a cmake build with these new options enabled? I ran into some cmake errors when trying to build with these new options (Ubuntu 22.04): Cannot use the deb embree package:
Error during cmake Generate step for cutlass:
|
It looks like the embree failure is a packaging error that has been fixed in Debian bookworm and later, namely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @roehling
C++ unit tests pass with cmake -DUSE_SYSTEM_EMBREE=ON -DUSE_SYSTEM_CUTLASS=ON -DWITH_MINIZIP=ON -DBUILD_CUDA_MODULE=ON ..
USE_SYSTEM_STDGPU is not tested since deb package is not available yet.
FYI the stdgpu package with CUDA support is available in Debian unstable now: |
Motivation and Context
These are changes to the build system which have been applied for the Debian packaging. The pull request intends to minimize divergence between upstream and Debian.
Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
This PR combines multiple patches:
Add option USE_SYSTEM_EMBREE
makes it possible to build Open3D using the system-installed Embree libraryAdd option USE_SYSTEM_STDGPU
does the same for stdgpuAdd option USE_SYSTEM_CUTLASS
does the same for cutlassAdd workaround for missing TBBConfig.cmake
improves compatibility with a few older Debian and Ubuntu versions where the system TBB has a broken CMake configuration file.Add option WITH_MINIZIP
is a simple way to add theunzip.h
header if the system zlib library does not provide it (OFF
by default, used in the Debian build)Add support to set Sphinx build date
facilitates reproducible builds, the build date in the documentation can be set to the release date and is no longer dependent on the actual build time.This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)